Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: GBM - hide "Display mode" setting #14120

Merged
merged 1 commit into from
Jun 29, 2018

Conversation

a1rwulf
Copy link
Member

@a1rwulf a1rwulf commented Jun 27, 2018

I think this setting makes no sense for gbm.

Description

Settings show something like <?0?> for me and kodi locks up in a black screen if you change it.

Motivation and Context

Windowed mode in GBM is not possible right?

How Has This Been Tested?

Linux GBM -> Setting is not there anymore

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@lrusak not sure how it was handled before, maybe you have another idea?

@a1rwulf a1rwulf added Type: Fix non-breaking change which fixes an issue v18 Leia labels Jun 27, 2018
@a1rwulf a1rwulf added this to the Leia 18.0-alpha3 milestone Jun 27, 2018
@a1rwulf a1rwulf requested a review from lrusak June 27, 2018 21:36
@a1rwulf
Copy link
Member Author

a1rwulf commented Jun 29, 2018

ping @lrusak in case it slipped through.

Copy link
Contributor

@lrusak lrusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! On LE we are doing the same thing already and I just never noticed....

@lrusak lrusak merged commit 773ed31 into xbmc:master Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants