Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup] silence compiler warnings #14144

Merged
merged 6 commits into from
Jul 6, 2018
Merged

[cleanup] silence compiler warnings #14144

merged 6 commits into from
Jul 6, 2018

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Jul 4, 2018

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added Type: Fix non-breaking change which fixes an issue Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia labels Jul 4, 2018
@Rechi Rechi added this to the Leia 18.0-alpha3 milestone Jul 4, 2018
notspiff
notspiff reviewed Jul 4, 2018
View reviewed changes
xbmc/view/ViewStateSettings.cpp Outdated
@@ -123,7 +123,7 @@ bool CViewStateSettings::Load(const TiXmlNode *settings)
if (pElement != NULL)
{
int settingLevel;
if (XMLUtils::GetInt(pElement, XML_SETTINGLEVEL, settingLevel, (const int)SettingLevel::Basic, (const int)SettingLevel::Expert))
if (XMLUtils::GetInt(pElement, XML_SETTINGLEVEL, settingLevel, (int)SettingLevel::Basic, (int)SettingLevel::Expert))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

xbmc/addons/PVRClient.cpp Outdated
@@ -1731,9 +1731,10 @@ class CCodecIds
CCodecIds(void)
{
// get ids and names
AVCodec* codec = NULL;
const AVCodec* codec = NULL;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

fritsch
fritsch reviewed Jul 4, 2018
View reviewed changes
xbmc/utils/ScraperParser.cpp
@@ -285,7 +285,7 @@ void CScraperParser::ParseExpression(const std::string& input, std::string& dest

if (iOptional > -1) // check that required param is there
{
char temp[4];
char temp[12];

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@Rechi Rechi merged commit 7cea231 into xbmc:master Jul 6, 2018
@Rechi Rechi deleted the cleanup/warnings branch July 6, 2018 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritsch fritsch fritsch left review comments

@notspiff notspiff notspiff left review comments

Assignees
No one assigned
Labels
Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rechi @fritsch @notspiff