RetroPlayer: Fix segfault when loading game #14146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cause of the segfault is libretro cores that fail to allocate input resources during initialization. Instead, input resources are allocated when the game is loaded. To accomodate this, we move our controller connecting/disconnecting to after the game is loaded. This commit also corrects the order of init/deinit for other game add-on resources.
This guards against an edge case where, in rare circumstances, an audio/video stream could fail to open, causing a segfault. Observed during testing, but not in production.
garbear
added
Type: Fix
|
jenkins build this please |
70 tasks
KOPRajs
added a commit
to KOPRajs/xbmc
that referenced
this pull request
Nov 21, 2018
This was referenced Nov 22, 2018
nsenica
pushed a commit
to PIPplware/xbmc
that referenced
this pull request
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a segfault that occurs when connecting a controller before loading a game in some cores.
This is valid behavior according to the libretro API, however multiple cores fail to fully allocate input resources until after the game is loaded, leading to segfaults. To fix this, we just defer connecting controllers until after loading the game.
A second fix for a potential segfault (only observed while testing) is also included.
How Has This Been Tested?
Tested on OSX with Beetle-PSX
Types of change