Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[videplayer][pvr] Fix a crash when stopping playback while teletext is opened. #14155

Merged
merged 1 commit into from
Jul 6, 2018

Conversation

ace20022
Copy link
Member

@ace20022 ace20022 commented Jul 5, 2018

Call chain:

CGUIDialogTeletext::OnInitWindow -> CTeletextDecoder::InitDecoder() -> 
CApplicationPlayer::GetTeletextCache() -> VideoPlayerTeletex::GetTeletextCache()

Now GUIDialogTeletext access the cache via the pointer hold by the TeletextDecoder. It points to a member variable of VideoPlayerTeletex. When playback is stopped the VideoPlayer deletes its VideoPlayerTeletex.
Later the dialog calls its OnDeinitWindow method and that calls CTeletextDecoder::EndDecoder() which tries to access the cache.

@ace20022 ace20022 added Type: Fix non-breaking change which fixes an issue Component: PVR Component: Video v18 Leia labels Jul 5, 2018
@ace20022 ace20022 requested a review from FernetMenta July 5, 2018 20:02
Copy link
Contributor

@FernetMenta FernetMenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ace20022 ace20022 merged commit 04ceaea into xbmc:master Jul 6, 2018
@ace20022 ace20022 deleted the teletext branch July 6, 2018 14:52
@Rechi Rechi added this to the Leia 18.0-alpha3 milestone Jul 6, 2018
@ghost
Copy link

ghost commented Jul 8, 2018

Now the active page gets lost when leaving and re-entering teletext, and I'm reset to the default #100. I'd be glad if that could be fixed.
Btw.: I'd appreciate [a configuration option] to get rid of the fading effect when entering/leaving teletext.
Milhouse suggested an Estuary feature request, but all other skins I've checked show the same behaviour, so it's probably located elsewhere (Player?).

@ace20022
Copy link
Member Author

ace20022 commented Jul 8, 2018

I'd be glad if that could be fixed.

I think I know why this happens. I'll try to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Component: Video Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants