Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Games: Add setting to disable autosave #14169

Merged
merged 3 commits into from
Jul 18, 2018
Merged

Conversation

garbear
Copy link
Member

@garbear garbear commented Jul 10, 2018

How autosave works:

If a game supports serialization, it is autosaved alongside the rom (e.g. Mario.smc creates Mario.sav and Mario.xml).

This happens when the game is closed. It also happens every 10 seconds in case of power outage. When the game is resumed, the last savestate is loaded.

This PR adds a setting to disable autosave.

Also includes:

  • refactor to avoid polluting settings source folder
  • a missing forward-declaration that was interfering with code completion

Motivation and Context

Reported in March: https://forum.kodi.tv/showthread.php?tid=173361&pid=2709320#pid2709320

How Has This Been Tested?

Tested on Linux x64 with several GBA cores. When disabled, no autosaves are created or loaded.

Screenshots (if appropriate):

autosave setting

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@garbear garbear added Type: Feature non-breaking change which adds functionality v18 Leia Component: Games labels Jul 10, 2018
@garbear garbear added this to the Leia 18.0-alpha3 milestone Jul 10, 2018
@garbear
Copy link
Member Author

garbear commented Jul 15, 2018

jenkins build this please

1 similar comment
@garbear
Copy link
Member Author

garbear commented Jul 18, 2018

jenkins build this please

@garbear garbear merged commit 3231481 into xbmc:master Jul 18, 2018
@garbear garbear deleted the autosave-setting branch July 18, 2018 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Games Type: Feature non-breaking change which adds functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant