Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] Uniformize "not available" string usage #14185

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

hudokkow
Copy link
Member

@hudokkow hudokkow commented Jul 15, 2018

Description

  • N/A, Not available, Unavailable and ? are now Not available except where N/A is requested (CSysInfo::GetHddSpaceInfo).
  • Removed hardcoded N/A except on CCPUInfo. Will be dealt with later.
  • Made N/A translatable. In my native language that would be N/D
  • Deprecated a couple of very low strings (161 and 416) but kept them because they might be used by older skins.

What's the policy? Drop deprecated strings completely and force the use of the new string?

Motivation and Context

Noticed this while looking at CSysInfoand CCPUInfo spaghetti.

How Has This Been Tested?

Run time tested under Ubuntu and Win x64.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@hudokkow hudokkow added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Improvement non-breaking change which improves existing functionality Component: Skin v18 Leia labels Jul 15, 2018
@MartijnKaijser
Copy link
Member

MartijnKaijser commented Jul 15, 2018

Drop deprecated strings completely and force the use of the new string?

Drop :)

@hudokkow hudokkow force-pushed the not_available_yet_try_later branch 2 times, most recently from ce3fe57 to ab2da6c Compare July 16, 2018 14:14
@hudokkow hudokkow force-pushed the not_available_yet_try_later branch from ab2da6c to 59568ed Compare July 16, 2018 20:17
@hudokkow
Copy link
Member Author

Thanks @MartijnKaijser

@hudokkow hudokkow added this to the Leia 18.0-alpha3 milestone Jul 16, 2018
@hudokkow hudokkow merged commit c1baadd into xbmc:master Jul 16, 2018
@hudokkow hudokkow deleted the not_available_yet_try_later branch July 16, 2018 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Skin Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants