[JSON]Fix filtering in GetSongs and GetAlbums

[DaveTBlake]

Fix path filtering in AudioLibrary::GetSongs and filtering by playcount, lastplayed or dateadded in AudioLibrary::GetAlbums after changes of #14160.

JSON API version bump patch as only internal processing change.

Can be tested with JSON commands:

{"jsonrpc": "2.0", "id": 1, "method": "AudioLibrary.GetAlbums", 
"params": { "filter": {"operator": "is", "field": "playcount", "value": "1"},
"properties": [ "lastplayed"] }}

{"jsonrpc":"2.0","id":1,"method":"audioLibrary.GetSongs",
"params":{"limits": {"start": 0, "end": 600},
"filter": {"operator": "contains", "field": "path", "value": "bruckner"},
"properties":["displayartist", "file"]}}

[DaveTBlake]

Win10 test build available here @zag2me or @rmrector if you would care to test it
http://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20180719-5293ee88-PR14201-merge-x64.exe

[zag2me]

Tested on windows and confirmed this fixes the SQL error I found while using the Artwork beef Add-on.

Thanks!

[MilhouseVH]

@DaveTBlake there's an issue with the first GetAlbums query and MySQL (btw it should be playcount not playedcount):

curl -s --data-binary '{"jsonrpc": "2.0", "id": 1, "method": "AudioLibrary.GetAlbums", "params": { "filter": {"operator": "is", "field": "playcount", "value": "1"}, "properties": [ "lastplayed"] }}' -H 'content-type: application/json;' http://localhost:8080/jsonrpc

results in

{"error":{"code":-32603,"message":"Internal error."},"id":1,"jsonrpc":"2.0"}

and in kodi.log:

09:57:51.509 T:1718379376   DEBUG: CWebServer[8080]: request received for /jsonrpc
09:57:51.580 T:1718379376   DEBUG: GetAlbumsByWhereJSON query: SELECT album.idAlbum, strAlbum, (SELECT ROUND(AVG(song.iTimesPlayed)) FROM song WHERE song.idAlbum = album.idAlbum) AS iTimesPlayed, (SELECT MAX(song.lastplayed) FROM song WHERE song.idAlbum = album.idAlbum) AS lastplayed FROM album  WHERE (((CAST(iTimesPlayed as DECIMAL(5,1)) = 1))) AND (album.strReleaseType = 'album') ORDER BY album.idAlbum
09:57:51.588 T:1718379376   ERROR: SQL: [MyMusic72] Undefined MySQL error: Code (1054)
                                            Query: SELECT album.idAlbum, strAlbum, (SELECT ROUND(AVG(song.iTimesPlayed)) FROM song WHERE song.idAlbum = album.idAlbum) AS iTimesPlayed, (SELECT MAX(song.lastplayed) FROM song WHERE song.idAlbum = album.idAlbum) AS lastplayed FROM album  WHERE (((CAST(iTimesPlayed as DECIMAL(5,1)) = 1))) AND (album.strReleaseType = 'album') ORDER BY album.idAlbum
09:57:51.589 T:1718379376   ERROR: GetAlbumsByWhereJSON failed

The query is:

SELECT album.idAlbum, strAlbum, 
       (SELECT ROUND(AVG(song.iTimesPlayed))
        FROM song
        WHERE song.idAlbum = album.idAlbum) AS iTimesPlayed, 
       (SELECT MAX(song.lastplayed)
        FROM song
        WHERE song.idAlbum = album.idAlbum) AS lastplayed
FROM album
WHERE (((CAST(iTimesPlayed as DECIMAL(5,1)) = 1))) AND (album.strReleaseType = 'album')
ORDER BY album.idAlbum

and when running this query in MySQL Workbench, the error is:

Error Code: 1054. Unknown column 'iTimesPlayed' in 'where clause'

Which is nasty.

The following query works, but I'm not suggesting it's a good solution...

SELECT * FROM
(
  SELECT album.idAlbum, strAlbum,
         (SELECT ROUND(AVG(song.iTimesPlayed))
          FROM song
          WHERE song.idAlbum = album.idAlbum) AS iTimesPlayed, 
         (SELECT MAX(song.lastplayed)
          FROM song
          WHERE song.idAlbum = album.idAlbum) AS lastplayed
  FROM album
  WHERE album.strReleaseType = 'album'
) as album
WHERE (((CAST(iTimesPlayed as DECIMAL(5,1)) = 1)))
ORDER BY album.idAlbum

[DaveTBlake]

Thanks for testing @MilhouseVH, darn substandard MySQL strikes again!
Anyway I have adjusted GetAlbums to handle it, only "albums" has scalar subquery fields as possible filter criteria. Could you test GetAlbums again please, in case I have slipped again.

[MilhouseVH]

I've tested the two queries in this PR again, and the MySQL issue is resolved. I've also repeated the testing from the previous PR, and those queries continue to return the expected results. Many thanks @DaveTBlake, this looks good to me.