Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RetroPlayer] Configure renderer sooner #14203

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

GTechAlpha
Copy link
Contributor

Description

Reconfigure renderer(s) when required by a zero-copy buffer. Clear pending buffers on buffer request, regardless of state. Don't reconfigure while already configuring. Include render parameters in buffer lock.

Motivation and Context

Minor RetroPlayer rendering improvement.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@garbear
Copy link
Member

garbear commented Jul 20, 2018

Confirmed that this fixes the crash in PCSX. Thanks.

@matejmosko
Copy link

matejmosko commented Jul 21, 2018

Hi, for me this didn't solve the crash in psx games. Upgraded to milhouse's build 720 and no change. Psx games still crash kodi.

Rpi3, libreelec.

@GTechAlpha GTechAlpha deleted the rp_config_sooner branch July 21, 2018 10:22
@GTechAlpha
Copy link
Contributor Author

You will need a LibreELEC build with the latest pcsx-rearmed that includes libretro/pcsx_rearmed#178 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Games Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants