VideoPlayer: fix aspect ratio of libass subs #14224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FernetMenta
added
Type: Fix
|
@FernetMenta Please revert this. it's not a fix, it's make a problem. see #14789 |
|
storage aspect ratio (SAR) = aspect ratio in frame we set use ass_set_margins |
|
I certainly won't revert this because it did fix an issue. if there is an issue with 3D, it has to be fixed without breaking other behaviour. |
|
ok. can you send me the sample file in that forum thread, I can't access google.com and want to try fix 3d issue without breaking other behavior. |
|
@taxigps what method works for you? (file is 10mb) |
|
@taxigps on our ftp server /samples/subs |
|
@FernetMenta @MartijnKaijser Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes wrong positioned overlays