New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add missing Player infolabels/boolean conditions #14261
Conversation
xbmc/GUIInfoManager.cpp
Outdated
/// \table_row3{ <b>`Player.PlaySpeed`</b>, | ||
/// \anchor Player_PlaySpeed | ||
/// _string_, | ||
/// Returns the player playback speed (tempo) with the format %1.2f (1.00 means normal playback speed) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
/// \table_row3{ <b>`Player.HasPrograms`</b>, | ||
/// \anchor Player_HasPrograms | ||
/// _boolean_, | ||
/// Returns true if the media file being played has programs\, i.e. groups of streams. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
3a08861
to
e8d2d96
Compare
xbmc/GUIInfoManager.cpp
Outdated
/// \table_row3{ <b>`Player.PlaySpeed`</b>, | ||
/// \anchor Player_PlaySpeed | ||
/// _string_, | ||
/// Returns the player playback speed (tempo) with the format %1.2f (1.00 means normal |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
e8d2d96
to
25da3cf
Compare
25da3cf
to
4068e73
Compare
@FernetMenta fixed, thanks 👍 |
probably a bit of nitpicking ;) at line 388: Line 380 in 4068e73
and at line 409: Line 409 in 4068e73
There are comments Same counts for probably take a look: I didn´t PRd that as I saw you are working on the same file ;). Feel free to pick that as well ;) |
Thanks @DaVukovic, cherry-picked your commit |
Thanks! |
Description
Adds missing player infolabels/boolean conditions docs, namely:
Player.HasGame
Player.TempoEnabled
Player.IsTempo
Player.PlaySpeed
Player.HasResolutions
Player.HasPrograms
Motivation and Context
Have complete docs. Those labels/bools are exposed to python and skins so an effort to clearly state what they do in simple terms is important.
The ultimate goal is to deprecate the respective wiki page as it is tremendously outdated. In follow up PR's I'll continue to track missing doc entries, complement with important info that may be present in the wiki and add information regarding which Kodi version a particular infolabel/bool was introduced.
How Has This Been Tested?
compiled docs
Pings:
@FernetMenta, @peak3d, @spiff
Types of change
Checklist: