Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for (external)player from playercorefactory.xml gets the default #14291

Merged
merged 1 commit into from Aug 14, 2018

Conversation

popy2k14
Copy link
Contributor

@popy2k14 popy2k14 commented Aug 11, 2018

Description

When you define an playercorefactory.xml file with an rule the behaviour should be:

  • if the filename has "4K" in it, kodi should launch the external player

  • if the filename has NOT "4K" in it, kodi should play it with the default player

But the behaviour is:

  • After Kodi start: if the filename has NOT "4K" in it, kodi playes it with internal video player. When you play more files with no 4K in filename, no issue. Default internal videoplayer is used.

  • If play a single file with "4K" in the filename, kodi launches the external player.

  • After you played one file with the external player, KODI IS PLAYING ALL FILES WITH THE EXTERNAL PLAYER. It doesnt care about the filename.

Motivation and Context

Because its an bug.
Here is the trac ticket: https://trac.kodi.tv/ticket/17983#ticket
And the forum thread post: https://forum.kodi.tv/showthread.php?tid=43511&pid=2757968#pid2757968

How Has This Been Tested?

Test on my local dev PC and on my main HTPC.
All tests was positive that the bug is fixed.

Screenshots (if appropriate):

Types of change

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • [ X] My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • [X ] I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@@ -115,7 +115,16 @@ bool CApplicationPlayer::OpenFile(const CFileItem& item, const CPlayerOptions& o
return true;
}
}


This comment was marked as spam.

@@ -116,6 +116,15 @@ bool CApplicationPlayer::OpenFile(const CFileItem& item, const CPlayerOptions& o
}
}

//check if player has changed?
if (player && (player->m_name != newPlayer))

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

…player in kodi when once playing an item with it.
@popy2k14
Copy link
Contributor Author

popy2k14 commented Aug 13, 2018

@FernetMenta & @Rechi
PR updated, review and merge please.

@FernetMenta
Copy link
Contributor

thanks!

@FernetMenta FernetMenta merged commit d270e1b into xbmc:master Aug 14, 2018
@Rechi Rechi added Type: Fix non-breaking change which fixes an issue Component: Video Platform: Windows v18 Leia labels Aug 14, 2018
@Rechi Rechi added this to the Leia 18.0-beta1 milestone Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants