New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for (external)player from playercorefactory.xml gets the default #14291
Conversation
xbmc/ApplicationPlayer.cpp
Outdated
@@ -115,7 +115,16 @@ bool CApplicationPlayer::OpenFile(const CFileItem& item, const CPlayerOptions& o | |||
return true; | |||
} | |||
} | |||
|
|||
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
45407c9
to
c88bc7a
Compare
xbmc/ApplicationPlayer.cpp
Outdated
@@ -116,6 +116,15 @@ bool CApplicationPlayer::OpenFile(const CFileItem& item, const CPlayerOptions& o | |||
} | |||
} | |||
|
|||
//check if player has changed? | |||
if (player && (player->m_name != newPlayer)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…player in kodi when once playing an item with it.
c88bc7a
to
dbe64f1
Compare
@FernetMenta & @Rechi |
thanks! |
Description
When you define an playercorefactory.xml file with an rule the behaviour should be:
if the filename has "4K" in it, kodi should launch the external player
if the filename has NOT "4K" in it, kodi should play it with the default player
But the behaviour is:
After Kodi start: if the filename has NOT "4K" in it, kodi playes it with internal video player. When you play more files with no 4K in filename, no issue. Default internal videoplayer is used.
If play a single file with "4K" in the filename, kodi launches the external player.
After you played one file with the external player, KODI IS PLAYING ALL FILES WITH THE EXTERNAL PLAYER. It doesnt care about the filename.
Motivation and Context
Because its an bug.
Here is the trac ticket: https://trac.kodi.tv/ticket/17983#ticket
And the forum thread post: https://forum.kodi.tv/showthread.php?tid=43511&pid=2757968#pid2757968
How Has This Been Tested?
Test on my local dev PC and on my main HTPC.
All tests was positive that the bug is fixed.
Screenshots (if appropriate):
Types of change
Checklist: