[json-rpc] Fix playback of pvr channels and pvr recordings - trac#17984. #14301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
|
Works here - thx @ksooo |
a1rwulf
approved these changes
Aug 15, 2018
|
Git label all very nice, but if you are changing internals then the JSON schema version patch number needs to bump too please, then it is easy for consumers of the API to trace what has changed and why. That is edit https://github.com/xbmc/xbmc/blob/master/xbmc/interfaces/json-rpc/schema/version.txt, the final digit is the patch number |
|
So where's the problem? |
|
So it has, but wasn't when I looked. Most odd. |
|
It was always there - at least in this PR. Seems you mixed up this PR with the PR by a1rwulf that was super seeded by this PR. a1rwulf's PR did not have the version bump. ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds #14299
Fixes trac#17984 (https://trac.kodi.tv/ticket/17984)
@a1rwulf fyi - could you runtime test this, please?