Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Remove circular dependency on CPowerManager #14305

Merged
merged 1 commit into from Aug 21, 2018

Conversation

garbear
Copy link
Member

@garbear garbear commented Aug 16, 2018

This removed one (of many) of settings' dependencies. Enum values were placed in a new files because settings still relies on the value, but at least the depend on PowerManager is broken.

@FernetMenta is the use of a reference here OK because settings is always available?

Motivation and Context

Split out from #14302.

How Has This Been Tested?

Compiles and runs on OSX.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@FernetMenta
Copy link
Contributor

is the use of a reference here OK because settings is always available

@garbear I think it is ok for now and points out the issue we have with settings: we should split them by components.

@garbear
Copy link
Member Author

garbear commented Aug 20, 2018

jenkins build this please

@garbear garbear merged commit f01f932 into xbmc:master Aug 21, 2018
@garbear garbear deleted the circular-deps3 branch August 21, 2018 17:27
@MartijnKaijser MartijnKaijser added this to the Leia 18.0-beta1 milestone Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants