Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUIWindowVideoNav.cpp: Fix comparison bug #14321

Merged
merged 1 commit into from Aug 19, 2018
Merged

Conversation

garbear
Copy link
Member

@garbear garbear commented Aug 18, 2018

While tracking down compiler warnings, I came across a tautological compare that is probably a bug.

The warning given was:

GUIWindowVideoNav.cpp:1043:15: warning: comparison of unsigned enum expression >= 0 is always true [-Wtautological-unsigned-enum-zero-compare]
      if (ret >= 0)
          ~~~ ^  ~

I think the author meant to write it as in this PR.

Introduced in #3017.

Motivation and Context

Noticed when tracking down compiler warnings for #14309

How Has This Been Tested?

Untested.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Noticed due to compiler warning:

GUIWindowVideoNav.cpp:1043:15: warning: comparison of unsigned enum expression >= 0 is always true [-Wtautological-unsigned-enum-zero-compare]
      if (ret >= 0)
          ~~~ ^  ~
@garbear garbear added Type: Fix non-breaking change which fixes an issue v18 Leia labels Aug 18, 2018
@garbear garbear merged commit 79b8328 into xbmc:master Aug 19, 2018
@garbear garbear deleted the fix-comparison branch August 19, 2018 18:28
@MartijnKaijser MartijnKaijser added this to the Leia 18.0-beta1 milestone Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants