[PVR] Fixes for hidden channels #14329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
Rechi
reviewed
Aug 20, 2018
| @@ -498,9 +498,10 @@ int CPVRChannelGroup::GetMembers(CFileItemList &results, bool bGroupMembers /* = | |||
|
|
|||
| for (PVR_CHANNEL_GROUP_SORTED_MEMBERS::const_iterator it = channels->m_sortedMembers.begin(); it != channels->m_sortedMembers.end(); ++it) | |||
| { | |||
| if (bGroupMembers || !IsGroupMember((*it).channel)) | |||
| const CPVRChannelPtr channel = (*it).channel; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Jalle19
reviewed
Aug 20, 2018
| @@ -498,9 +498,10 @@ int CPVRChannelGroup::GetMembers(CFileItemList &results, bool bGroupMembers /* = | |||
|
|
|||
| for (PVR_CHANNEL_GROUP_SORTED_MEMBERS::const_iterator it = channels->m_sortedMembers.begin(); it != channels->m_sortedMembers.end(); ++it) | |||
| { | |||
| if (bGroupMembers || !IsGroupMember((*it).channel)) | |||
| const CPVRChannelPtr channel = (*it).channel; | |||
| if (bGroupMembers != channel->IsHidden() || !IsGroupMember(channel)) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ksooo
force-pushed
the
pvr-fix-hidden-channels
branch
from
91c4e78
to
a9feab4
Compare
|
@Jalle19 cleaned up the mess. Should be more readable now (speaking not about the diff, but the code ;-) |
Jalle19
approved these changes
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two small issues with hidden channels, reported in the forum: https://forum.kodi.tv/showthread.php?tid=333402
Runtime tested on macOS, latest Kodi master.
@Jalle19 if you are around, mind taking a look?