Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windowing: GBM - fix window system initialization #14331

Merged
merged 1 commit into from Aug 21, 2018
Merged

Windowing: GBM - fix window system initialization #14331

merged 1 commit into from Aug 21, 2018

Conversation

a1rwulf
Copy link
Member

@a1rwulf a1rwulf commented Aug 20, 2018

InitWindowSystemEGL is called from InitWindowSystem
after register calls to various factories
and thus must not clear hwaccels nor the renderer.

Motivation and Context

Fixes playback of an avi file mentioned in IRC.

How Has This Been Tested?

Tested playback with GL and GLES on Ubuntu.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@a1rwulf
Windowing: GBM - fix window system initialization
1059587 
InitWindowSystemEGL is called from InitWindowSystem
after register calls to various factories
and thus must not clear hwaccels nor the renderer.
@a1rwulf a1rwulf added this to the Leia 18.0-beta1 milestone Aug 20, 2018
@a1rwulf a1rwulf requested a review from lrusak August 20, 2018 21:00
lrusak
lrusak approved these changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@lrusak lrusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@a1rwulf
Copy link
Member Author

a1rwulf commented Aug 21, 2018

Also confirmed by the reporting user.

@a1rwulf a1rwulf merged commit 0bc7140 into xbmc:master Aug 21, 2018
@a1rwulf a1rwulf deleted the gbm-fix-render-register branch October 10, 2018 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrusak lrusak lrusak approved these changes

Assignees
No one assigned
Labels
Component: Video rendering Component: Video Platform: Linux Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Milestone
Leia 18.0-beta1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@a1rwulf @lrusak