Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Estuary] Music OSD: Remove 'Previous' button for non-seekable stream… #14381

Merged

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Sep 1, 2018

Music OSD: Remove 'Previous' button for non-seekable streams and if player has no previous item.

"Previous" button in music OSD has two functions. First, go to the previous track in playlist, or go back to the beginning of the playing track. If both it not possible, because the stream is either the first in playlist and/or not seekable (live audio stream), the "Previous" button should be removed from the OSd. This PR implements exactly this change.

Runtime-tested on macOS, latest Kodi master.

@DaveTBlake fyi
@ronie for review of the skin change?

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: Music Component: Skin v18 Leia labels Sep 1, 2018
@ksooo ksooo added this to the Leia 18.0-beta2 milestone Sep 1, 2018
@ksooo ksooo requested a review from ronie September 1, 2018 21:18
Copy link
Member

@ronie ronie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

@ksooo ksooo merged commit 4420f0c into xbmc:master Sep 3, 2018
@ksooo ksooo deleted the music-osd-no-previous-button-for-live-streams branch September 3, 2018 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Music Component: Skin Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants