[gui] Add icon for Blu-rays. #14418
Merged
[gui] Add icon for Blu-rays. #14418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ace20022
added
Type: Improvement
|
Any specific reason to not put it in v18? Does it have issues with multiple drives? |
I thought it is a problem that the icon is missing. And it needs more testing, especially on non win desktop platforms. |
|
here you go, click below: |
|
@ace20022 here's a better version: |
ace20022
force-pushed
the
drive_icon
branch
from
b6ac0cc
to
4557ebe
Compare
|
The last commit only has an effect if folder stacking is disabled. For bds I want to add a thumb from the bds meta data if possible. |
ace20022
force-pushed
the
drive_icon
branch
from
4557ebe
to
2a12e82
Compare
ksooo
reviewed
Sep 21, 2018
| { | ||
| SetIconImage("DefaultBluray.png"); | ||
| } | ||
| else if (IsDVDFolder()) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #6946. It's not optimal, especially when there are multiple drives available, but I have not time to work me in that part and refactor it.
Could someone please make the icon DefaultBluray.png? Maybe @ronie?
In memory of @un1versal.