Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller dialog: Make it more awesome #14494

Merged
merged 4 commits into from Oct 2, 2018
Merged

Conversation

garbear
Copy link
Member

@garbear garbear commented Sep 30, 2018

This improves the controller dialog in several ways:

First, @da-anda and @pkerling removed all logos from controllers in kodi-game/controller-topology-project#30. Just to be safe.

Next, I've exposed the controller descriptions I wrote as part of the Controller Topology Project. Even though logos are gone, we could still be targeted by <insert litigious game company>. Showing descriptions strengthens our argument for fair use because it becomes informative and historical.

Next, because it's so awesome to read descriptions about all controllers, I added "Get all" button below the "Get more..." button to install the entire controller topology project. I've never observed anyone actually using the "Get more..." button, but I wanted a way to install everything in one click.

Next, I removed some code that hides controllers with no mappable features, such as hubs and unfinished controllers. Even though they can't be mapped, with descriptions, it's still fun to read about them.

Finally, I fixed a bug that didn't refresh controller profiles when new ones are installed.

TODO: When the list refreshes with a new controller, it should be made active.

Motivation and Context

Adding ideas that came to me during my DevCon presentation in Sofia.

How Has This Been Tested?

It probably hard-crashes on startup.

But seriously, test builds are here: https://github.com/garbear/xbmc/releases/tag/retroplayer-18beta3-20181001

Screenshots (if appropriate):

Controller descriptions:

screen shot 2018-09-30 at 1 30 06 pm

"Get all" dialog:

screen shot 2018-09-30 at 1 30 17 pm

Progress dialog while installing controller add-ons:

screen shot 2018-09-30 at 1 31 02 pm

Controller profile with nothing to map:
screen shot 2018-09-30 at 1 33 10 pm

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@garbear garbear added Type: Fix non-breaking change which fixes an issue Component: Skin v18 Leia Component: Games labels Sep 30, 2018
@garbear
Copy link
Member Author

garbear commented Oct 2, 2018

Test builds uploaded: https://github.com/garbear/xbmc/releases

@garbear garbear merged commit 8f3aeab into xbmc:master Oct 2, 2018
@garbear garbear deleted the controller-dialog branch October 2, 2018 14:15
@Rechi Rechi added this to the Leia 18.0-beta3 milestone Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Games Component: Skin Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants