Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[guilib] GUIBaseContainer: Add support for ACTION_PLAYER_PLAY #14513

Merged
merged 1 commit into from Oct 3, 2018

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Oct 3, 2018

This changes make it possible to use the "Play" button on remote/keyboard on items selected on the Estuary home screen widgets, like videos, songs, Live TV channels, PVR recordings, ...

IMO, it feels quite natural to start playback of media items with the "Play" button. ;-)

@da-anda what do you think about this small improvement?

@ksooo ksooo added Type: Improvement non-breaking change which improves existing functionality v18 Leia labels Oct 3, 2018
@ksooo ksooo added this to the Leia 18.0-beta4 milestone Oct 3, 2018
@da-anda
Copy link
Member

da-anda commented Oct 3, 2018

awesome ❤️ ! Ran into this "issue" several times already. Didn't expect the fix for this to be just a one-liner though :)

@ksooo ksooo merged commit 4e8fd14 into xbmc:master Oct 3, 2018
@ksooo ksooo deleted the action-player-play branch October 3, 2018 19:31
@garbear
Copy link
Member

garbear commented Oct 19, 2018

@ksooo this causes an infinite loop, see #14653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants