Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[settings] Fix CSettings::UninitializeISettingsHandlers #14520

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Oct 4, 2018

CSettings::UninitializeISettingsHandlers was a complete mess (maybe copy/paste error initially and than things went mad).

The method now:

  • deregisters settings handlers, not settings callbacks (c/p error in initial implementation?)
  • deregisters the handlers actually registered in CSettings::InitializeISettingsHandlers
  • uses exactly the revers order of registration to deregister

I runtime-tested the changes on macOS, latest Kodi master.

@Montellese if you are araound, pleaes take a look. If not, I will merge in a couple of days.

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: Settings v18 Leia labels Oct 4, 2018
@ksooo ksooo added this to the Leia 18.0-beta4 milestone Oct 4, 2018
@ksooo ksooo requested a review from Montellese October 4, 2018 11:04
@garbear
Copy link
Member

garbear commented Oct 4, 2018

@Montellese confirmed this was an implementation error when I noticed it a while ago, but I forgot to finish correcting this. Change looks good.

@ksooo
Copy link
Member Author

ksooo commented Oct 4, 2018

@garbear thanks for taking a look.

@ksooo ksooo merged commit 6ecc9a0 into xbmc:master Oct 4, 2018
@ksooo ksooo deleted the settings-fix-uninit-settingshandlers branch October 4, 2018 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Settings Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants