Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Game_Control should be a subpage of skin_controls #14530

Merged
merged 1 commit into from Oct 7, 2018

Conversation

enen92
Copy link
Member

@enen92 enen92 commented Oct 6, 2018

Description

Right now the game control doxygen page is shown as a menu entry on doxygen side bar. It should be in fact grouped with all the other skin controls.

Motivation and Context

Proper documentation for Leia. Group all skin controls on the same place.

How Has This Been Tested?

Compiled docs and manual testing

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@enen92 enen92 changed the title [docs] Game_Control should be a subpage of the skin_controls [docs] Game_Control should be a subpage of skin_controls Oct 6, 2018
@MartijnKaijser MartijnKaijser added this to the Leia 18.0-beta4 milestone Oct 6, 2018
@garbear
Copy link
Member

garbear commented Oct 6, 2018

I noticed that the Game Control is missing several parameters (<videofilter>, <stretchmode>, <videorotation>). I'll try to add these and their possible values.

@MartijnKaijser MartijnKaijser merged commit 44c7b80 into xbmc:master Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants