[pvr] Use correct title for recordings (if available) #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it seems to use the title from teletext (on dvdplayer)
|
Looks good to me. |
|
Is title really taken from teletext now? That seem wrong for any kind of |
|
@elupus Nope, this just affects recordings (respectively objects where HasVideoInfoTag() returns false). Then it calls g_application.m_pPlayer->GetPlayingTitle() where dvdplayer gets the title from teletext. |
ghost
assigned
opdenkamp
pushed a commit
that referenced
this pull request
Sep 27, 2012
[pvr] Use correct title for recordings (if available)
jmarshallnz
added a commit
that referenced
this pull request
Dec 25, 2013
Fix 14546 - ListItem.setInfo can handle additional types. Fixes #1456
LongChair
added a commit
to plexinc/plex-home-theater-public
that referenced
this pull request
Dec 15, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a small issue when playing recordings.
Currently the title for the ui is taken from teletext (dvdplayer) which is not always incorrect.
The PR changes GetVideoLabel to return the title from PVRRecordingInfoTag for recordings.