Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

[pvr] Use correct title for recordings (if available) #1456

Merged
merged 1 commit into from

4 participants

@fetzerch

This fixes a small issue when playing recordings.
Currently the title for the ui is taken from teletext (dvdplayer) which is not always incorrect.
The PR changes GetVideoLabel to return the title from PVRRecordingInfoTag for recordings.

@fetzerch fetzerch [pvr] Use correct title for recordings (if available)
Currently it seems to use the title from teletext (on dvdplayer)
7031a60
@Memphiz
Owner

Looks good to me.

@elupus
Collaborator
@fetzerch

@elupus Nope, this just affects recordings (respectively objects where HasVideoInfoTag() returns false). Then it calls g_application.m_pPlayer->GetPlayingTitle() where dvdplayer gets the title from teletext.

@opdenkamp opdenkamp was assigned
@opdenkamp opdenkamp merged commit 714e94a into xbmc:master
@LongChair LongChair referenced this pull request from a commit in plexinc/plex-home-theater-public
@LongChair LongChair Fix resuming with mkv transcoding, fixes #1456 d986a07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 21, 2012
  1. @fetzerch

    [pvr] Use correct title for recordings (if available)

    fetzerch authored
    Currently it seems to use the title from teletext (on dvdplayer)
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 0 deletions.
  1. +2 −0  xbmc/GUIInfoManager.cpp
View
2  xbmc/GUIInfoManager.cpp
@@ -3539,6 +3539,8 @@ CStdString CGUIInfoManager::GetVideoLabel(int item)
StringUtils::EmptyString :
g_localizeStrings.Get(19055); // no information available
}
+ if (m_currentFile->HasPVRRecordingInfoTag() && !m_currentFile->GetPVRRecordingInfoTag()->m_strTitle.IsEmpty())
+ return m_currentFile->GetPVRRecordingInfoTag()->m_strTitle;
if (m_currentFile->HasVideoInfoTag() && !m_currentFile->GetVideoInfoTag()->m_strTitle.IsEmpty())
return m_currentFile->GetVideoInfoTag()->m_strTitle;
// don't have the title, so use dvdplayer, label, or drop down to title from path
Something went wrong with that request. Please try again.