Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[settings] store default centermixlevel #14578

Merged
merged 1 commit into from Oct 10, 2018
Merged

[settings] store default centermixlevel #14578

merged 1 commit into from Oct 10, 2018

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Oct 10, 2018

Motivation and Context

fixes #14566

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added Type: Improvement non-breaking change which improves existing functionality Component: Settings Component: Audio v18 Leia labels Oct 10, 2018
@Rechi Rechi force-pushed the fix/centermixlevel branch 2 times, most recently from adc281a to ccd3cec Compare October 10, 2018 16:11
@razzeee razzeee added this to the Leia 18.0-beta4 milestone Oct 10, 2018
@Rechi Rechi merged commit 6acd9d8 into xbmc:master Oct 10, 2018
@Rechi Rechi deleted the fix/centermixlevel branch October 10, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernetMenta FernetMenta FernetMenta approved these changes

@razzeee razzeee razzeee approved these changes

Assignees
No one assigned
Labels
Component: Audio Component: Settings Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Milestone
Leia 18.0-beta4
Development

Successfully merging this pull request may close these issues.

Downmix: Centermix level setting not applying to all videos
3 participants
@Rechi @FernetMenta @razzeee