Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[binary-addons] add additional arguments to the build scripts #14594

Merged
merged 5 commits into from Oct 13, 2018

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Oct 12, 2018

Description

  • allow passing ADDON_SRC_PREFIX, ADDONS_DEFINITION_DIR, extra arguments to cmake via the build scripts
  • add packaging support for depends platforms
  • allow depends optimisations also for release configurations

Motivation and Context

needed for binary addons repo

How Has This Been Tested?

https://jenkins.kodi.tv/view/Addons/job/xbmc/

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added Component: Binary add-ons Component: Depends v18 Leia No Jenkins do not run automatic Jenkins builds on this PR labels Oct 12, 2018
@Rechi Rechi requested a review from wsnipex October 12, 2018 19:35
@Rechi Rechi force-pushed the feature/binaryAddonsJenkins branch from 44447ec to 130dd9a Compare October 12, 2018 20:29
Copy link
Member

@wsnipex wsnipex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@MartijnKaijser MartijnKaijser added this to the Leia 18.0-beta4 milestone Oct 13, 2018
@Rechi Rechi removed the No Jenkins do not run automatic Jenkins builds on this PR label Oct 13, 2018
@Rechi Rechi force-pushed the feature/binaryAddonsJenkins branch from 130dd9a to 2876b9c Compare October 13, 2018 07:10
@Rechi
Copy link
Member Author

Rechi commented Oct 13, 2018

The FreeBSD failure is unrelated as this PR only changes windows and depends build files, which aren't used.

@Rechi Rechi merged commit d50c051 into xbmc:master Oct 13, 2018
@Rechi Rechi deleted the feature/binaryAddonsJenkins branch October 13, 2018 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants