[windows] Add message to installer that add-ons have been removed #14605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartijnKaijser
added
Type: Improvement
|
I guess standard users do not know exactly what a binary addon is. Maybe complement the message with some information: ...binary addon (e.g. pvr, visualizations, inputstream, etc) ... ? |
garbear
reviewed
Oct 15, 2018
| @@ -143,6 +143,7 @@ Function HandleKodiInDestDir | |||
| StrCpy $CleanDestDir "0" | |||
| Abort | |||
| done: | |||
| MessageBox MB_OK|MB_ICONINFORMATION "All binary add-ons that were previously included by default in the installer have been moved to the Kodi repository. You will have to install the ones you previously used from the repository.$\nYour add-on settings itself are kept intact and will be used again after installing the add-on." | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
MartijnKaijser
force-pushed
the
installer_warning
branch
from
3734b83
to
0cc6c00
Compare
MartijnKaijser
removed
the
No Jenkins
…m the installer and added to Kodi repository.
MartijnKaijser
force-pushed
the
installer_warning
branch
from
0cc6c00
to
4847db3
Compare
|
Already build this one for windows so no need to wait for jenkins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warn users on install that add-on have been moved to repo. This warning is only given if they install in existing location.
How Has This Been Tested?
Running the installer.
Screenshots (if appropriate):