Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] make-addons: remove surrounding quotation marks #14620

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Oct 16, 2018

Motivation and Context

This allows to pass a regex without having to escape the special characters multiple times

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@@ -10,16 +10,17 @@ SET store=

SETLOCAL EnableDelayedExpansion
FOR %%b IN (%*) DO (
IF %%b == install (
echo %%~b

This comment was marked as spam.

This comment was marked as spam.

@Rechi Rechi force-pushed the fix/windowsBuildScript branch 2 times, most recently from 3fe5d16 to b3d794c Compare October 16, 2018 09:51
This allows to pass a regex without having to escape the special characters multiple times
@Rechi Rechi merged commit 6c5725e into xbmc:master Oct 16, 2018
@Rechi Rechi deleted the fix/windowsBuildScript branch October 16, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants