Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[depends][configure] Disable asserts on release builds (typo fix) #14623

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

VelocityRa
Copy link
Member

Description

Fixes a typo in configure.ac, effectively disabling asserts on Release builds, as intended.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

Effectively disables asserts on Release builds, as intended.
@VelocityRa VelocityRa added Type: Fix non-breaking change which fixes an issue Component: Depends labels Oct 16, 2018
@razzeee
Copy link
Member

razzeee commented Oct 16, 2018

jenkins build and merge

@razzeee razzeee added this to the Leia 18.0-beta4 milestone Oct 16, 2018
@MartijnKaijser MartijnKaijser merged commit 76d18a5 into xbmc:master Oct 16, 2018
@VelocityRa VelocityRa deleted the conf-typo-fix branch October 16, 2018 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Depends Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants