Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][win10] relocate InitOSKeymap after #14511 #14651

Merged
merged 1 commit into from Oct 20, 2018
Merged

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Oct 19, 2018

Description

CServiceBroker::GetSettingsComponent() is called at a time where it doesn't exist

Motivation and Context

fixes hard crash on start

How Has This Been Tested?

started Kodi and pressed a few buttons

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

CServiceBroker::GetSettingsComponent() is called at a time where it doesn't exist
@Rechi Rechi added Type: Fix non-breaking change which fixes an issue v18 Leia Platform: WindowsStore labels Oct 19, 2018
@Rechi Rechi added this to the Leia 18.0-beta4 milestone Oct 19, 2018
@Rechi Rechi merged commit 938146c into xbmc:master Oct 20, 2018
@Rechi Rechi deleted the fix/win10 branch October 20, 2018 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: WindowsStore Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants