Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PVR][Estuary] Add GUI for Radio Data System (RDS). #14731

Merged
merged 1 commit into from Oct 28, 2018
Merged

[PVR][Estuary] Add GUI for Radio Data System (RDS). #14731

merged 1 commit into from Oct 28, 2018

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Oct 27, 2018 •
edited

Kodi VideoPlayer supports Radio Data RDS (RDS) for a long time, btw, but somehow we forgot to add Estuary support...

The PR completes and fixes RDS core and Estuary support.

Before:

  • a rudimentary RDS info dialog which was not even directly accessible from Estuary:

screenshot000

After:

  • completely reworked RDS info dialog, accessible from PVR radio OSD
  • player info extended to display "rds" label if an RDS stream is available for the currently playing channel.
  • bonus: pvr radio OSD now has buttons for "channels" and "channel guide" (as Live TV OSD has)

screenshot002
screenshot001
screenshot018

For sure there is room for functional improvements, but this is for another day. ;-)

@ronie are the skin changes okay?
@Jalle19 mind doing a code review?
@da-anda fyi

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Type: Improvement non-breaking change which improves existing functionality Component: PVR Component: GUI engine v18 Leia labels Oct 27, 2018
@ksooo ksooo added this to the Leia 18.0-beta5 milestone Oct 27, 2018
@ksooo ksooo requested review from ronie and Jalle19 October 27, 2018 21:56
ronie
ronie reviewed Oct 27, 2018
View reviewed changes
addons/skin.estuary/xml/MusicOSD.xml Outdated
</include>
<onclick>Dialog.Close(MusicOSD)</onclick>
<onclick>ActivateWindow(PVROSDChannels)</onclick>
<visible>VideoPlayer.Content(LiveTV)</visible>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

addons/skin.estuary/xml/MusicOSD.xml Outdated
</include>
<onclick>Dialog.Close(MusicOSD)</onclick>
<onclick>ActivateWindow(PVRChannelGuide)</onclick>
<visible>VideoPlayer.Content(LiveTV) + VideoPlayer.HasEPG</visible>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

addons/skin.estuary/xml/Variables.xml Outdated
<value condition="String.IsEmpty(MusicPlayer.ChannelName)">$INFO[Player.Title]</value>
<value condition="String.IsEmpty(Player.Title)">$INFO[MusicPlayer.ChannelName]</value>
<value condition="String.IsEmpty(MusicPlayer.ChannelName) + String.IsEmpty(Player.Title)"></value>
<value>$INFO[MusicPlayer.ChannelName] - $INFO[Player.Title]</value>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@da-anda
Copy link
Member

da-anda commented Oct 28, 2018

awesome work. Thanks so much for spending time on this

@ksooo
Copy link
Member Author

ksooo commented Oct 28, 2018

Jenkins error is unrelated.

@ksooo ksooo merged commit f237c7e into xbmc:master Oct 28, 2018
@ksooo ksooo deleted the estuary-rds branch October 28, 2018 11:47
@AlwinEsch
Copy link
Member

@ksooo Thanks a lot!

This way on xml looks much much better and the way how it handled on code is cool and brilliant.

Looks so much better than my kind of before.

@AlwinEsch AlwinEsch requested review from AlwinEsch and removed request for AlwinEsch October 28, 2018 16:24
@ksooo
Copy link
Member Author

ksooo commented Oct 28, 2018

Thanks for the kind words, Alwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronie ronie ronie left review comments

@Jalle19 Jalle19 Jalle19 approved these changes

Assignees
No one assigned
Labels
Component: GUI engine Component: PVR Type: Fix non-breaking change which fixes an issue Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Milestone
Leia 18.0-beta5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ksooo @da-anda @AlwinEsch @ronie @Jalle19