[VideoPlayer] SetResolution synchronously instead RM::TriggerResolution #14755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peak3d
added
Type: Improvement
FernetMenta
reviewed
Oct 31, 2018
| m_renderManager.TriggerUpdateResolution(static_cast<float>(framerate), hint.width, hint.stereo_mode); | ||
| RESOLUTION res = CResolutionUtils::ChooseBestResolution(static_cast<float>(framerate), hint.width, hint.height, !hint.stereo_mode.empty()); | ||
| CServiceBroker::GetWinSystem()->GetGfxContext().SetVideoResolution(res, false); | ||
| //RenderManager::UpdateLatencyTweak() should be called automatically as soon GUIFullScreenWindow is ready |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
FernetMenta
reviewed
Oct 31, 2018
| @@ -128,7 +129,6 @@ class CRenderManager | |||
| void DeleteRenderer(); | |||
| void ManageCaptures(); | |||
|
|
|||
| void UpdateLatencyTweak(); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@FernetMenta PR updated. |
FernetMenta
reviewed
Oct 31, 2018
| @@ -141,6 +141,7 @@ bool CRenderManager::Configure(const VideoPicture& picture, float fps, unsigned | |||
| m_dvdClock.SetVsyncAdjust(0); | |||
| m_pConfigPicture.reset(new VideoPicture()); | |||
| m_pConfigPicture->CopyRef(picture); | |||
| UpdateLatencyTweak(); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
jenkins build this please |
FernetMenta
approved these changes
Oct 31, 2018
|
This PR introduced playback issues on Raspberry Pi. If during a live TV playback I try to play a file - I get a spinning circle and playback does not start. This does not happen with all videos, mostly with .ts and .m2ts. Debug log - https://paste.kodi.tv/epixewujah.kodi |
7 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Process initial resolution change (if requested in settings / from stream) synchronously on VideoPlayer startup instead using the asynchronous RenderManager::TriggerUpdateResolution.
Motivation and Context
If user has enabled "Adjust display refresh rate" and whitelist includes a resolution matching to the stream to play, we switch resolution / refresh rate on supported devices.
The current async workflow can lead to rough video startup.
This PR processes the ResolutionChange (for fullscreen video playback) before VP initializes the underlying processes. Video playback with resolution change starts with getting screen black and smooth playback afterwards.
Please note, that handling of resolution changes during playback is not changed, its still async.
How Has This Been Tested?
Types of change