Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addons] Switch from TVDB to TMDB as default TV show scraper #14898

Merged
merged 2 commits into from Nov 18, 2018

Conversation

MartijnKaijser
Copy link
Member

Description

  • removed TVDBD scraper
  • added TMDB scraper
  • adjusted addon manifest
  • adjusted default scraper in settings.xml

Motivation and Context

Past time there has been increasing problems with TVDB API and website. TMDB in that regard is much more stable and is on the same level of information content (or even better)

How Has This Been Tested?

By assumption

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@MartijnKaijser
Copy link
Member Author

Note: look at the two commits separately cause github thinks i moved files as there are certainly similarities between the two scraper addons

@ronie
Copy link
Member

ronie commented Nov 18, 2018

i think you also need to adjust this file:
https://github.com/xbmc/xbmc/blob/master/cmake/installdata/common/addons.txt

- added TMDB scraper
- adjusted addon manifest
- adjusted default scraper in settings.xml
@MartijnKaijser
Copy link
Member Author

thx. Updated

@MartijnKaijser MartijnKaijser added this to the Leia 18.0-rc1 milestone Nov 18, 2018
@MartijnKaijser MartijnKaijser merged commit b638220 into xbmc:master Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants