[settings] Hide episode thumb if unseen (core wise)

[DaVukovic]

Description

This is a similar change to #14914, but done in core. I also followed a suggestion to change the wordings for that setting to make it less confusing. To be pretty clear, and for the reason we have another option for the "Show plot/information"-setting, I also decided to change the option labels to show exactly what is meant.

The only problem I can't solve myself (hence I added the "Help wanted" labe)l is, that the home screen TV show widgets don't change to the OverlaySpoiler image until the skin was reloaded (after playing a video, restarting Kodi, finish a database update, whatever). @Rechi helped me, but I don't get it ;). So I would love to see some help from someone who might be interested.

Motivation and Context

Same as for #14914

How Has This Been Tested?

Tested on Ubuntu 16.04

Screenshots (if appropriate):

See the PR mentioned above, The screenshots will be the same.

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[DaVukovic]

@notspiff I mentioned you in case you are interested. If not, then sorry for the noise.

[Hitcher]

@DaVukovic RE: The home screen widgets not updating.

This is actually a problem with home screen widgets in general (see below), not just specific to your PR, so this is good go in my opinion.

To reproduce for other widgets simply find a movie in your library that's displayed on the home screen in Estuary, change the poster and go back home. Old poster is still shown until you either refresh the skin or play a video.

[DaVukovic]

@HitcherUK Yeah, I see what you mean. @Rechi PRd a hack to my branch, which I merged currently and I can confirm that announcing OnScanFinished after the change of that setting at least refreshes the widgets. Also a skin reload would do that. I know that this is a hack and probably not the method we will do that in the future, but I can confirm it working. The widgets are refreshed fine now and the setting has an immediate effect.

[Hitcher]

Thanks, this will make a lot of people happy.

[MartijnKaijser]

Is this PR ok to be merged after its squashed?

[Rechi]

No still needs a change, but @DaVukovic knows what to change.

[DaVukovic]

squashed the commits and also renamed the topic for a better match ;)

[Hitcher]

@MartijnKaijser I believe this is good to go now.