-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmake] Fix ninja (fixes: #15008) #15011
Conversation
updated |
jenkins build this please |
Tested this with LibreELEC and it's all good with the addition of the fixup commit (xbmc.json/addon.xml isn't installed without the fixup commit). Thanks @wsnipex |
jenkins build this please |
Can this please be considered for Kodi 18? |
I'd like confirmation that it doesn't somehow break windows first |
On that note, should Travis and/or Appveyor be configured to use ninja? Also, is Travis still used? Travis seems to be disabled for xbmc/xbmc, and when I run it on my own, the build fails due to missing flatbuffers. (If it isn't used, can |
Seems fine @wsnipex ran a Windows x64 build and JSON commands were working as expected. |
Hi, could you please merge into feature_python3 branch and I will test it there. [Edit] I patched my local copy of feature_python3 branch with your commit and it built successfully. |
Just cherry-pick it ... Edit: Did not see your Edit |
Description
remove duplicate output target for addons/xbmc.json/addon.xml
Motivation and Context
see #15008
How Has This Been Tested?
only quickly on ubuntu. I'm not 100% certain this does not have an side effects...
Screenshots (if appropriate):
Types of change
Checklist: