Resolution: Don't add half refreshrates by default #15016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You might want to note that this is only applicable if the whitelist is empty. Users can still allow these modes to be used if they want by selecting them in the whitelist. |
|
Yes. Added accordingly. |
|
@fritsch Is this for v18? |
|
Other shall decide. Due to other activites I don't have much time anymore. I don't want to cause trouble. |
|
imho this should go into v18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kodi cannot reliably distinguish between 25p and 50i or 29.97p and 60i on playback start, especially for LiveTV. Therefore don't expose those modes by default to workaround this issue, so that users don't switch refreshrate twice when zapping.
With an empty whitelist only this will break e.g. 3840@25p playback for HDMI 1.4 users (fallback to 1080p50) and will by default play 1080p25 content at 1080p50 putting more load on embedded systems, cause going through the guilayer twice as often as needed if e.g. subtitle cases.
Background: https://forum.kodi.tv/showthread.php?tid=298462&pid=2798167#pid2798167 or #14973
Obviously users can properly configure their whitelist (Expert Setting) to enable those modes themselves. This above logic will only ever apply if user has enabled Refreshrate switching but has an empty whitelist.