Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolution: Don't add half refreshrates by default #15016

Merged
merged 1 commit into from Jan 3, 2019

Conversation

@fritsch
Copy link
Member

commented Dec 7, 2018

Kodi cannot reliably distinguish between 25p and 50i or 29.97p and 60i on playback start, especially for LiveTV. Therefore don't expose those modes by default to workaround this issue, so that users don't switch refreshrate twice when zapping.

With an empty whitelist only this will break e.g. 3840@25p playback for HDMI 1.4 users (fallback to 1080p50) and will by default play 1080p25 content at 1080p50 putting more load on embedded systems, cause going through the guilayer twice as often as needed if e.g. subtitle cases.

Background: https://forum.kodi.tv/showthread.php?tid=298462&pid=2798167#pid2798167 or #14973

Obviously users can properly configure their whitelist (Expert Setting) to enable those modes themselves. This above logic will only ever apply if user has enabled Refreshrate switching but has an empty whitelist.

@lrusak

This comment has been minimized.

Copy link
Contributor

commented Dec 7, 2018

You might want to note that this is only applicable if the whitelist is empty. Users can still allow these modes to be used if they want by selecting them in the whitelist.

@fritsch

This comment has been minimized.

Copy link
Member Author

commented Dec 7, 2018

Yes. Added accordingly.

@fritsch fritsch force-pushed the fritsch:refreshrate2 branch from 0eed100 to 3ced145 Dec 7, 2018

@pkerling

This comment has been minimized.

Copy link
Member

commented Dec 21, 2018

@fritsch Is this for v18?

@fritsch

This comment has been minimized.

Copy link
Member Author

commented Dec 21, 2018

Other shall decide. Due to other activites I don't have much time anymore. I don't want to cause trouble.

@wsnipex

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

imho this should go into v18

@MartijnKaijser MartijnKaijser added this to the Leia 18.0-rc5 milestone Jan 3, 2019

@MartijnKaijser MartijnKaijser merged commit 7026905 into xbmc:master Jan 3, 2019

1 check passed

default You're awesome. Have a cookie
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.