Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] make sure APP_BUILD_DATE is always set #15028

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Conversation

wsnipex
Copy link
Member

@wsnipex wsnipex commented Dec 10, 2018

Description

fix build date when GIT_VERSION is set

Motivation and Context

reported by @MilhouseVH in #15004 (comment)

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@wsnipex wsnipex added Type: Fix non-breaking change which fixes an issue CMake v18 Leia labels Dec 10, 2018
@MilhouseVH
Copy link
Contributor

Many thanks - this now works fine with LibreELEC when setting GIT_VERSION!

@wsnipex wsnipex merged commit b788e08 into xbmc:master Dec 11, 2018
@Rechi Rechi added this to the Leia 18.0-rc3 milestone Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants