Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMALCodec: Keep videBuffer valid until next decode picture #15042

Merged
merged 2 commits into from
Dec 13, 2018

Conversation

popcornmix
Copy link
Member

Description

MMALCodec: Keep videBuffer valid until next decode picture

Motivation and Context

#14986

How Has This Been Tested?

In milhouse nightly. Confirmed fix by reporter.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

VideoPlayerVideo expects this and it is required for DVD menus
to be updated correctly.
I did catch a seg-fault inside mmal_port_pool_destroy that was presumably caused by component being deleted first
@DaVukovic
Copy link
Member

@MartijnKaijser I guess we can push the button here, Fix is confirmed by the user and issue is closed.

@MartijnKaijser MartijnKaijser merged commit 64da515 into xbmc:master Dec 13, 2018
@Rechi Rechi added this to the Leia 18.0-rc3 milestone Dec 13, 2018
@popcornmix popcornmix deleted the mmaldvd branch December 13, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants