Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMLCodec: fix contrast setting #15047

Merged
merged 1 commit into from
Dec 16, 2018
Merged

Conversation

samnazarko
Copy link
Contributor

Description'

This fixes contrast setting to match what the kernel expects.

Motivation and Context

This can be fixed in the kernel; but changes are unlikely to be made here for a variety of platforms; so this quick fix is probably better.

How Has This Been Tested?

Tested on AMLogic 3.10 and 3.14

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

Signed-off-by: Sam Nazarko <email@samnazarko.co.uk>
@lrusak lrusak added Type: Fix non-breaking change which fixes an issue Platform: Linux v18 Leia Platform: AMLogic labels Dec 13, 2018
@lrusak lrusak added this to the Leia 18.0-rc3 milestone Dec 13, 2018
@lrusak
Copy link
Contributor

lrusak commented Dec 13, 2018

@samnazarko is there a reason this was set to 255? is there a chance that some amlogic kernel use that value?

@samnazarko
Copy link
Contributor Author

This comes with 3.0.x kernels (early MX6 days).
As Kodi + amcodec only supports >=3.10; this is the correct way to handle this.

@MartijnKaijser
Copy link
Member

jenkins build this please

1 similar comment
@MartijnKaijser
Copy link
Member

jenkins build this please

@MartijnKaijser MartijnKaijser merged commit 5c2ecda into xbmc:master Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: AMLogic Platform: Linux Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants