Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[settings] Fix announcement call #15070

Merged
merged 1 commit into from
Dec 16, 2018
Merged

Conversation

DaVukovic
Copy link
Member

Description

This change should fix #15060 as I added a new type and probably OnRefresh could also be used for other scenarios where a home screen reload might be necessary.

Motivation and Context

Fixes the segfault at #15060

How Has This Been Tested?

Runtime tested on Ubuntu 16.04 against latest Kodi master.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@DaVukovic DaVukovic added Type: Fix non-breaking change which fixes an issue Component: Settings v18 Leia labels Dec 15, 2018
@MartijnKaijser MartijnKaijser added this to the Leia 18.0-rc3 milestone Dec 16, 2018
@MartijnKaijser
Copy link
Member

Confirmed working

@MartijnKaijser MartijnKaijser merged commit 9bb1313 into xbmc:master Dec 16, 2018
@DaveTBlake
Copy link
Member

Glad that the seg fault has been fixed. However the new "VideoLibrary.OnRefresh" notification message also needs to be added to the JSON API, and the schema minor version (middle number) bumped to indicate a change has happened.

@DaVukovic like to raise PR for that please. An addition similar to the following (and inserted below it) is what is needed

"VideoLibrary.OnCleanFinished": {
"type": "notification",
"description": "The video library has been cleaned.",
"params": [
{ "name": "sender", "type": "string", "required": true },
{ "name": "data", "type": "null", "required": true }
],
"returns": null
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Settings Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kodi segfaults on start.
3 participants