[PluginDirectory] - ensure that Abort of ScriptObserver waits for thread exit - fix crash&burn #15204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead exit to prevent bad access of already destroyed event object
Memphiz
added
Type: Fix
Memphiz
changed the title
|
@Memphiz just a nit: as far as I am aware we usually don't add platform labels if something affects all platforms Change itself looks good to me :-) also thanks @FernetMenta! |
MartijnKaijser
added a commit
to MartijnKaijser/xbmc
that referenced
this pull request
Jan 22, 2019
[PluginDirectory] - ensure that Abort of ScriptObserver waits for thread exit - fix crash&burn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents bad access of already destroyed event object during a race condition.
Once of the Mac OS users was hit by that crash in a really reproducible manner. He also confirmed the fix.
Thx to @FernetMenta for the finding of the root cause.
This crash hits all platforms and might have happened whenever a plugin listing is opened or a movie is played via the plugin:// uri scheme