[Android] Log kernel ThreadId instead pthread_self #15263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartijnKaijser
pushed a commit
to MartijnKaijser/xbmc
that referenced
this pull request
Jan 22, 2019
[Android] Log kernel ThreadId instead pthread_self
fritsch
reviewed
Feb 2, 2019
| } | ||
|
|
||
| bool CThread::IsCurrentThread(const ThreadIdentifier tid) | ||
| { | ||
| #if defined(TARGET_ANDROID) | ||
| return gettid() == tid; |
There was a problem hiding this comment.
https://forum.kodi.tv/showthread.php?tid=339983 <- any chance this might go wrong?
There was a problem hiding this comment.
Refering to the logs it doesn't seem to be an issue caused by this PR, the thread ids are increasing, no resuage there. So I would say no
peak3d
added a commit
to peak3d/xbmc
that referenced
this pull request
Feb 4, 2019
7 tasks
MartijnKaijser
added a commit
that referenced
this pull request
Feb 4, 2019
[Threads] revert #15263, log tid instead posix thread
nsenica
pushed a commit
to PIPplware/xbmc
that referenced
this pull request
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Log kernel TID in log to make it compareable to android tools like top / systrace.
Motivation and Context
Make debugging more transparent
How Has This Been Tested?
AFTV4K, start kodi / read kodi.log
Types of change