fixed: NFO/tag loading for http/https sources was broken (fixes #15481) #15492
Conversation
| // don't try to read tags for streams | ||
| if (item.IsInternetStream()) | ||
| return nullptr; | ||
|
|
There was a problem hiding this comment.
@notspiff you directly programmed it like this. Removing it without discussion sounds not right.
There was a problem hiding this comment.
Alternatively we could move the NFO-reading up so it's before the IsInternetStream()-check, although I don't see why any of the stuff below it could be a problem for http/https.
There was a problem hiding this comment.
in principle there is no problem loading for http(s). but some servers will not like the Exists() and some for some streaming protocols it makes little sense. so i added it to lessen chance of issues and log spam. i don't see a big issue removing it as such, but that was the logic.
There was a problem hiding this comment.
Yes, I already suspected that. Since we've ran into this issue before I think we should see whether we can find another way to flag/distinguish between actual "streams" and "files" served from http/https but that's beyond the scope of this PR.
There was a problem hiding this comment.
Also be aware of shoutcasts (internet radio). I don't know if they would get to this part of code, but I know that they are often over looked and we had issues with determining it was a shoutcast outside the player (the player knows but does not publish the fact)
There was a problem hiding this comment.
If somebody tries to scan a shoutcast station into their video library they deserve it all.
|
So ,this is good to go? |
|
Do it. |
|
build error unrelated |
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
Checklist: