New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace GUIDialogVideoScan by the extended progress bar #1560
Conversation
objections? |
No objections here. |
Replace GUIDialogVideoScan by the extended progress bar
Not too sure about the main label jumping between 'Downloading movie information', 'Scanning for new content', 'Downloading TV show information', 'Scanning for new content', etc. EDIT: Maybe change the labels altogether as a lot of users have local NFO files and 'downloading' implies XBMC is getting the info from the internet? ie using existing strings - Library Update - Movies, Library Update - Music, etc |
Actually I can see what's going wrong here - 'Scanning for new content' should be used on the second line when no specific item is being scanned. |
@jmarshallnz Thoughts? |
Mind summarising what changes are needed? |
Previous examples Line 1 - Downloading TV show information Line 1 - Downloading movie information Current examples Line 1 - Downloading TV show information - Scanning for new content - Downloading TV show information - Scanning for new content etc Line 1 - Downloading movie information - Scanning for new content - Downloading movie information - Scanning for new content etc So to keep it like it was the first line needs to drop the 'Scanning for...' label which then needs moving to the second line and that needs to drop the path. |
I've had a look on this, and have played with moving the Scanning for new content to line 2 and dropping the path. The problem is that the movie name only shows up for such a short period of time, that it's almost always stuck on Scanning for new content, which isn't really informative. Also, the progress bar seems to be going all over the show. Will try and think of some improvements (perhaps using the directory name) tonight. |
Looks much nicer, thanks. |
That this pops up should not be a surprise.