Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Replace GUIDialogVideoScan by the extended progress bar #1560

Merged
2 commits merged into from Oct 8, 2012

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Oct 7, 2012

That this pops up should not be a surprise.

@ghost

ghost commented Oct 8, 2012

objections?

Member

jmarshallnz commented Oct 8, 2012

No objections here.

@ghost ghost self-assigned this Oct 8, 2012

ghost pushed a commit that referenced this pull request Oct 8, 2012

Merge pull request #1560 from cptspiff/novscan
Replace GUIDialogVideoScan by the extended progress bar

@ghost ghost merged commit 79ed7ae into xbmc:master Oct 8, 2012

Contributor

HitcherUK commented Oct 9, 2012

Not too sure about the main label jumping between 'Downloading movie information', 'Scanning for new content', 'Downloading TV show information', 'Scanning for new content', etc.

EDIT: Maybe change the labels altogether as a lot of users have local NFO files and 'downloading' implies XBMC is getting the info from the internet?

ie using existing strings - Library Update - Movies, Library Update - Music, etc

Contributor

HitcherUK commented Oct 10, 2012

Actually I can see what's going wrong here -

'Scanning for new content' should be used on the second line when no specific item is being scanned.

Contributor

HitcherUK commented Oct 13, 2012

@jmarshallnz Thoughts?

Member

jmarshallnz commented Oct 13, 2012

Mind summarising what changes are needed?

Contributor

HitcherUK commented Oct 13, 2012

Previous examples

Line 1 - Downloading TV show information
Line 2 - Scanning for new content - Alphas - 1x11 - Original Sin - Scanning for new content etc

Line 1 - Downloading movie information
Line 2 - Scanning for new content - Avatar - Scanning for new content etc

Current examples

Line 1 - Downloading TV show information - Scanning for new content - Downloading TV show information - Scanning for new content etc
Line 2 - Q:/tvshows/alphas/ - Alphas - 1x11 - Original Sin - Q:/movies/alphas/ - Alphas - 2x01 - Wake-up Call etc

Line 1 - Downloading movie information - Scanning for new content - Downloading movie information - Scanning for new content etc
Line 2 - Q:/movies/alien/ - Alien - Q:/movies/avatar/ - Avatar etc

So to keep it like it was the first line needs to drop the 'Scanning for...' label which then needs moving to the second line and that needs to drop the path.

@JezzX @ronie @jmarshallnz

Member

jmarshallnz commented Oct 16, 2012

I've had a look on this, and have played with moving the Scanning for new content to line 2 and dropping the path. The problem is that the movie name only shows up for such a short period of time, that it's almost always stuck on Scanning for new content, which isn't really informative. Also, the progress bar seems to be going all over the show.

Will try and think of some improvements (perhaps using the directory name) tonight.

Contributor

HitcherUK commented Oct 18, 2012

Looks much nicer, thanks.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment