Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Don't flip GLES if window was destroyed #15641

Merged
merged 1 commit into from Mar 1, 2019

Conversation

Projects
None yet
1 participant
@peak3d
Copy link
Contributor

commented Mar 1, 2019

Description

If window is destroyed (no surface to render GL available) we should avoid to render on it to avoid abort exceptions. This is what this PR is doing.

Motivation and Context

Remove more ANR's / crashes

How Has This Been Tested?

  • Enable kill background tasks in android phone settings.
  • Launch kodi
  • Switch of screen from mobile.

Without PR you'll find a fatal abort in kodi.log

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@peak3d peak3d added this to the Leia 18.2-rc1 milestone Mar 1, 2019

@peak3d peak3d merged commit dc942a4 into xbmc:master Mar 1, 2019

1 check passed

default You're awesome. Have a cookie
Details

@peak3d peak3d deleted the peak3d:flip branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.