Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: obtaining movie name for stacks #15736

Merged
merged 1 commit into from Apr 3, 2019

Conversation

Projects
None yet
3 participants
@notspiff
Copy link
Contributor

commented Mar 13, 2019

Description

In particular this was broken for stacks with files inside archives in in separate directories (cdx/*.rar)

@notspiff notspiff added the v18 Leia label Mar 14, 2019

@notspiff notspiff added this to the Leia 18.2-rc1 milestone Mar 14, 2019

@notspiff

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

silence is acceptance?

for( int i=1;i<items.Size();++i)
{
items[i]->m_strDVDLabel = GetDirectory(items[i]->GetPath());
if (IsProtocol(items[0]->m_strDVDLabel, "rar") || IsProtocol(items[0]->m_strDVDLabel, "zip"))
if (HasParentInHostname(url2))
items[i]->SetPath(GetParentPath(items[i]->m_strDVDLabel));

This comment has been minimized.

Copy link
@enen92

enen92 Mar 15, 2019

Member

Shouldn't it be dynpath here and the line below?

This comment has been minimized.

Copy link
@notspiff

notspiff Mar 15, 2019

Author Contributor

not afaik, as these ops only happens based on files, not library entries or the likes, ie, it works fine as-is. i'd prefer to keep this on topic.

@notspiff notspiff merged commit 9b00eee into xbmc:master Apr 3, 2019

1 check passed

default You're awesome. Have a cookie
Details

@notspiff notspiff deleted the notspiff:fix_stack_movie_name branch Apr 3, 2019

@Rechi Rechi added the Type: Fix label Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.