fixed: obtaining movie name for stacks #15736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
silence is acceptance? |
enen92
reviewed
Mar 15, 2019
| for( int i=1;i<items.Size();++i) | ||
| { | ||
| items[i]->m_strDVDLabel = GetDirectory(items[i]->GetPath()); | ||
| if (IsProtocol(items[0]->m_strDVDLabel, "rar") || IsProtocol(items[0]->m_strDVDLabel, "zip")) | ||
| if (HasParentInHostname(url2)) | ||
| items[i]->SetPath(GetParentPath(items[i]->m_strDVDLabel)); |
There was a problem hiding this comment.
Shouldn't it be dynpath here and the line below?
There was a problem hiding this comment.
not afaik, as these ops only happens based on files, not library entries or the likes, ie, it works fine as-is. i'd prefer to keep this on topic.
|
It looks like the change in GetMovieName() now incorrectly ignores the option *bUseFolderNames" in the case of stacks. And indeed in Kodi 18.2, if you activate the option "Movies are in separate folders that match the movie title" and try to import two files that are in a folder with a movie name and are named e.g. "part1.mkv" and "part2.mkv", the movie lookup and thus the import will fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In particular this was broken for stacks with files inside archives in in separate directories (cdx/*.rar)