-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controller dialog: Update controllers after controller addon installation #15763
Conversation
@enen92 can you test? |
Sorry for the delay @garbear. Tested it and working as expected 👍 |
Agreed. I haven't had time to include that fix in this PR, so I think it's best if we merge as-is and follow up with a fix to the problem that #15754 tries to solved. Can you rebase on master after this merge so we can re-evaluate your patch? jenkins build this please |
@garbear we are just in the middle of branching Leia. In case you want this fix in v18 you need to backport it to Leia branch. |
@ksooo I saw the branching discussion in slack too late. Do you recommend backporting? |
Description
This PR is a continuation of the UX fix in #15754.
The first commit adds the missing add-on events that caused the list to not refresh when an add-on is installed.
However, this led to the following problem:
The SNES controller was selected, but installing a 3DO controller updated the controller list indices and caused the wrong one to be highlighted. To fix this, I made the controller dialog focus the newly installed controller.
How Has This Been Tested?
Installed a controller and observed it being focused.
Clicked "Get all", and controllers were updated as they were installed. Unfortunately, the image is blocked by the modal dialog. I would like to make it a toast, but then how would the user cancel? Closing the dialog?
Types of change