Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DialogVideoInfo: do not reset the current listitem before play #15764

Merged
merged 1 commit into from May 23, 2019

Conversation

enen92
Copy link
Member

@enen92 enen92 commented Mar 17, 2019

Description

When listitems are played via the VideoInfo dialog the current ListItem is reset and a new CFileItem is created using the previous ListItem VideoInfoTag. In case the previous item did not have an infotag, the new CFileItem path is set to the older listitem path while the remaining listitem information is lost/recreated. The option to play from beginning or resume the playback for an item takes into account the fact of the item being a folder (m_bisFolder) which by default is set to true. Resume options only are displayed if the item is not a folder.

When adding plugin directories we have the option to specify if the listitem is a folder. Playable items are added by defining the isPlayable property to true and setting isFolder to false. Since the isFolder info is lost when we play from the video info dialog, the video is always played from the beginning. Different behaviour happens when playing from the the regular plugin window containing the item list.

Motivation and Context

Fixes #15581

How Has This Been Tested?

Played several items from the video info dialog:

  • movies
  • tvshow episodes
  • plugins
  • movies or episodes in playlists

Checked the old behaviour was retained for all the items but for plugins we now get the option to resume playback.

Screenshots (if appropriate):

alt text

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@enen92 enen92 added Type: Fix non-breaking change which fixes an issue Component: GUI engine v18 Leia labels Mar 17, 2019
@Rechi Rechi removed the v18 Leia label Apr 16, 2019
@jenkins4kodi jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label May 3, 2019
@enen92 enen92 added this to the Matrix 19.0-alpha 1 milestone May 15, 2019
@jenkins4kodi jenkins4kodi removed the Rebase needed PR that does not apply/merge cleanly to current base branch label May 15, 2019
@enen92
Copy link
Member Author

enen92 commented May 15, 2019

jenkins build this please

@enen92
Copy link
Member Author

enen92 commented May 15, 2019

Any objections / can somebody review? PR was first created 2 months ago.
Maybe let it in and see if any issues are found?

@notspiff notspiff merged commit eb5f02f into xbmc:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GUI engine Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not resuming xbmcgui.ListItem from DialogVideoInfo.xml
4 participants