DialogVideoInfo: do not reset the current listitem before play #15764
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When listitems are played via the VideoInfo dialog the current ListItem is reset and a new
CFileItem
is created using the previous ListItemVideoInfoTag
. In case the previous item did not have an infotag, the newCFileItem
path is set to the older listitem path while the remaining listitem information is lost/recreated. The option to play from beginning or resume the playback for an item takes into account the fact of the item being a folder (m_bisFolder
) which by default is set to true. Resume options only are displayed if the item is not a folder.When adding plugin directories we have the option to specify if the listitem is a folder. Playable items are added by defining the
isPlayable
property to true and settingisFolder
to false. Since theisFolder
info is lost when we play from the video info dialog, the video is always played from the beginning. Different behaviour happens when playing from the the regular plugin window containing the item list.Motivation and Context
Fixes #15581
How Has This Been Tested?
Played several items from the video info dialog:
Checked the old behaviour was retained for all the items but for plugins we now get the option to resume playback.
Screenshots (if appropriate):
Types of change