Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[Music]Show artist disambiguation text when picking which one to scrape #15773
When refreshing the artist information for an artist, if MusicbrainzID is unknown and the name is not unique then the user is presented with a list of artists to choose from. This is usually just a list of names, many the same, and is pretty useless leaving the user to find the right artist by trail and error.
Musicbrainz returns disambiguation text which is idea information to help the user identify the right artist, and this fix ensures this information gets displayed. See example of Darius after this change
This use of disambiguation text value should have been added when use of this Musicbrainz data was added elsewhere by #12963 but was accidentally omitted. It was also always intended for this dialog to have more information to help the user choose e.g. year, genre, but neither get returned to the by the scraper request to Musicbrainz to find artist by name.
Well tested and a low risk localised change, hope another team member will approve for 18.2
Looks good, this is exactly how I do it on TADB imports as well. The disambiguation text is generally good enough to differentiate the Artists.
The only other thing that might be useful (in the future) is the country of the artist. I show a little flag and that helps a lot when choosing between them but the 2 letter ISO text code could also work just as well.