Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Music]Show artist disambiguation text when picking which one to scrape #15773

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
3 participants
@DaveTBlake
Copy link
Member

commented Mar 19, 2019

When refreshing the artist information for an artist, if MusicbrainzID is unknown and the name is not unique then the user is presented with a list of artists to choose from. This is usually just a list of names, many the same, and is pretty useless leaving the user to find the right artist by trail and error.

Here is a screenshot for artist called Darius (93 to choose from)
Imgur

Musicbrainz returns disambiguation text which is idea information to help the user identify the right artist, and this fix ensures this information gets displayed. See example of Darius after this change
Imgur

This use of disambiguation text value should have been added when use of this Musicbrainz data was added elsewhere by #12963 but was accidentally omitted. It was also always intended for this dialog to have more information to help the user choose e.g. year, genre, but neither get returned to the by the scraper request to Musicbrainz to find artist by name.

Well tested and a low risk localised change, hope another team member will approve for 18.2

@zag2me

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

Looks good, this is exactly how I do it on TADB imports as well. The disambiguation text is generally good enough to differentiate the Artists.

The only other thing that might be useful (in the future) is the country of the artist. I show a little flag and that helps a lot when choosing between them but the 2 letter ISO text code could also work just as well.

EDIT: pic
Image1

Show artist disambiguation text to help user select which artist they…
… are scraping by when no mbid and scraper has found more than one artist with that name.

Add disambiguation, gender and type to Python scraper artist processing.

@DaveTBlake DaveTBlake force-pushed the DaveTBlake:SelectArtistToScrape branch from afbdeb9 to 55271ab Mar 19, 2019

@ronie

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

great improvement, that dialog makes much more sense now.

@DaveTBlake DaveTBlake merged commit 8659884 into xbmc:master Mar 21, 2019

1 check passed

default You're awesome. Have a cookie
Details

@DaveTBlake DaveTBlake deleted the DaveTBlake:SelectArtistToScrape branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.