Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Timers context menu 'Find similar' missing #15779

Merged
merged 1 commit into from Mar 20, 2019

Conversation

Projects
None yet
2 participants
@linknetx
Copy link
Contributor

commented Mar 20, 2019

Description

Adds the 'Find similar' context menu option to the PVR timers list context menu.

Motivation and Context

Fixes missing 'Find similar' timers list context menu option.

Currently the timer list context menu shows the 'Programme information' option which then gives the 'Find similar' option in the subsequent 'Programme information' window , so it makes sense to include 'Find similar' in the preceding context menu.

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi requested a review from ksooo Mar 20, 2019

@ksooo

ksooo approved these changes Mar 20, 2019

Copy link
Member

left a comment

Looks good. Thanks.

@ksooo ksooo added this to the Leia 18.2-rc1 milestone Mar 20, 2019

@ksooo ksooo merged commit bac95d3 into xbmc:master Mar 20, 2019

1 check passed

default You're awesome. Have a cookie
Details

@linknetx linknetx deleted the linknetx:pvr-find-similar branch Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.