Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[depends] binary-addons: fix libGL.so location #15787

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
3 participants
@Rechi
Copy link
Member

commented Mar 21, 2019

Description

Instead of /usr/lib/<HOST>/mesa/libGL.so use Instead of /usr/lib/<HOST>/libGL.so.
/usr/lib/<HOST>/mesa/libGL.so only existed in Ubuntu Trusty (14.04) and Xenial (16.04). It doesn't exist any-more in Ubuntu Bionic (18.04) and also doesn't exist in any still supported Debian version.
/usr/lib/<HOST>/libGL.so exists in Ubuntu Xenial (16.04) so there is no need for a special case.

Motivation and Context

I noticed that all screensavers fail to build for Linux on the Ubuntu Bionic (18.04) VM.

How Has This Been Tested?

successfully compiled a screensaver on Debian

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi force-pushed the Rechi:fix/addons-libGL-location branch from 41b94ee to 93a0ad7 Mar 21, 2019

@AlwinEsch
Copy link
Member

left a comment

To have this fix is very good, installed on the weekend jenkins on my system (Ubuntu 19.04) to test on all OS and was needed to make a link from this to the required and become build working.

@Rechi Rechi merged commit 40d5b22 into xbmc:master Mar 21, 2019

1 check passed

default You're awesome. Have a cookie
Details

@Rechi Rechi deleted the Rechi:fix/addons-libGL-location branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.